This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Sync manifest changes from data-science-pipelines PRs #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
2 similar comments
|
/retest |
|
/retest |
gmfrasca
force-pushed
the
update-dsp-manifests
branch
from
f7f5319
to
b3178bc
Compare
|
/uncc |
|
/retest |
gmfrasca
force-pushed
the
update-dsp-manifests
branch
from
b3178bc
to
044d84e
Compare
|
/retest |
|
/approve @gmfrasca The dashboard tile won't be supported with the ODH Core deployment until the ODH Core 1.4.1 release |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
gmfrasca
force-pushed
the
update-dsp-manifests
branch
from
f3ffd44
to
db2a6bc
Compare
gmfrasca
force-pushed
the
update-dsp-manifests
branch
from
db2a6bc
to
03b76e6
Compare
|
/retest |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default-configsoverlay not included, allowing user to specify their own database/s3 object store providers, etc without ODH operator overwritting them)How Has This Been Tested?
To test, simply apply the kfdef to a cluster with a running ODH Operator: /kfdefs/kfctl_openshift_ds-pipelines.yaml
Verify by accessing the ds-pipeline-ui route, running the example pipeline, etc.
You can also access the route via
Launch Applicationlink in ODH Dashboard after Enabling the Application from the Explore tab.Merge criteria: