Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

change apiVersion to rbac.authorization.k8s.io/v1 to support kfctl on ODH 1.4.0 and OCP 4.10 #699

Conversation

shalberd
Copy link
Contributor

@shalberd shalberd commented Nov 11, 2022

fixes opendatahub-io/opendatahub-operator#187

apiVersion changes for roleBindings to be compatible with deployment via KfDef and version 1.4.0 of the operator on ODH 4.10

Description

openshift type notation led to errors when deploying manifests via KfDef.

How Has This Been Tested?

Made the changes in the PR, downloaded the 1.4.0 odh-manifests tar.gz, unpacked it, made changes locally, re-packed it, uploaded modified tar.gz to our server, then applied KfDef especially for Jupyter. On Openshift 4.10, with Operator 1.4.0. All roles, rolebindings, and clusterroles and clusterrolebindings are now present as they should be and the entire deployment is up and running.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…espace from RoleBinding of ref kind Role, remove params path roleRef/namespace for rolebinding
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2022

Hi @shalberd. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LaVLaS
Copy link
Contributor

LaVLaS commented Nov 15, 2022

/ok-to-test

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix. This worked for me

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6dbca8e into opendatahub-io:master Nov 16, 2022
@shalberd shalberd deleted the jupyterhub-apigroup-changes branch November 16, 2022 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterHub fails to deploy with 1.4 Operator
3 participants