This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
change apiVersion to rbac.authorization.k8s.io/v1 to support kfctl on ODH 1.4.0 and OCP 4.10 #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes opendatahub-io/opendatahub-operator#187
apiVersion changes for roleBindings to be compatible with deployment via KfDef and version 1.4.0 of the operator on ODH 4.10
Description
openshift type notation led to errors when deploying manifests via KfDef.
How Has This Been Tested?
Made the changes in the PR, downloaded the 1.4.0 odh-manifests tar.gz, unpacked it, made changes locally, re-packed it, uploaded modified tar.gz to our server, then applied KfDef especially for Jupyter. On Openshift 4.10, with Operator 1.4.0. All roles, rolebindings, and clusterroles and clusterrolebindings are now present as they should be and the entire deployment is up and running.
Merge criteria: