Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Remove the protocol from ceph-nano StatefulSet #701

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Nov 15, 2022

Signed-off-by: Landon LaSmith LLaSmith@redhat.com

Closes #698

Description

Removes the .spec.templates.spec.containers[].protocol from the ceph-nano StatefulSet since server-side apply is failing to create the object because it is not included in the StatefulSet schema.

How Has This Been Tested?

Deployed ceph-nano with this change to ensure that it deploys successfully with no errors during rollout related to

apiVersion: kfdef.apps.kubeflow.org/v1
kind: KfDef
metadata:
  name: odh-core
spec:
  applications:
  - kustomizeConfig:
      repoRef:
        name: manifests
        path: odh-common
    name: odh-common
  - kustomizeConfig:
      repoRef:
        name: manifests-ceph-nano
        path: ceph/object-storage/scc
    name: ceph-nano-scc
  - kustomizeConfig:
      repoRef:
        name: manifests-ceph-nano
        path: ceph/object-storage/nano
    name: ceph-nano
repos:
  - name: manifests
    uri: https://github.com/opendatahub-io/odh-manifests/tarball/master
  - name: manifests-ceph-nano
    uri: https://github.com/lavlas/odh-manifests/tarball/fix-ceph-nano

Merge criteria:

ceph-nano deploys successfully with odh-operator v1.4.0+

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Nov 16, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS LaVLaS merged commit 73941cc into opendatahub-io:master Nov 18, 2022
@LaVLaS LaVLaS deleted the fix-ceph-nano branch November 18, 2022 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ceph-nano containers.protocol not accepted on odh 1.4.0 on OCP 4.10.36 manifests tag 1.4.0
1 participant