Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Fix for the dashboard test failures #711

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Dec 5, 2022

  • Update the dashboard CI test for the new generic notebook name

Signed-off-by: Landon LaSmith LLaSmith@redhat.com

How Has This Been Tested?

Manual run of the peak test framework to reproduce the issue and confirm the fix

Merge criteria:

The dashboard CI test passes without any issues

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

* Update the dashboard CI test for the new generic notebook name

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Dec 5, 2022

/approve

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

@LaVLaS: you cannot LGTM your own PR.

In response to this:

/approve

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Dec 6, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@LaVLaS: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LaVLaS LaVLaS merged commit 181ea16 into opendatahub-io:master Dec 6, 2022
@LaVLaS LaVLaS deleted the fix-dashboard-ci-test branch December 6, 2022 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant