Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add kube-linter command to makefile #720

Merged

Conversation

mlassak
Copy link
Contributor

@mlassak mlassak commented Jan 23, 2023

Description

Added a manual command to makefile for kube-linter execution.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • The developer has manually tested the changes and verified that the changes work.

.kube-linter.yaml Outdated Show resolved Hide resolved
@mlassak mlassak force-pushed the feat/add-kube-linter-cmd branch 2 times, most recently from 2964c31 to af49794 Compare January 27, 2023 13:03
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mlassak
Copy link
Contributor Author

mlassak commented Feb 8, 2023

Thank you for your feedback, I changed the command names and added a new variable KUBE_LINTER_TARGET, specification of directory/file to lint can be done using make kube-lint KUBE_LINTER_TARGET=path/to/target.

@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 11, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit e465b8a into opendatahub-io:master Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants