Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update the CI test container to use chromium and chromedriver from epel repo #730

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Feb 13, 2023

Description

This PR updates the tests Dockerfile to install chomium and chromedriver to remove the need to manually sync the chromedriver version in the container every time there is a new chromium version

Signed-off-by: Landon LaSmith LLaSmith@redhat.com

How Has This Been Tested?

Built the CI test container locally
Ran the CI tests against a local deployment of ODH

Merge criteria:

CI tests run successfully with the new chromium and chromedriver versions

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…el repo

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cbaef3b into opendatahub-io:master Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants