Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Use test framework to use opendatahub-io/peak repo for testing #741

Merged

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Mar 2, 2023

Description

Updates the peak test framework to pull from repos under the opendatahub-io instead of references to user forks and other deprecated github organizations

How Has This Been Tested?

I built and deployed the test container locally then run the CI tests without any errors

Merge criteria:

Existing CI tests run without any issues

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@anishasthana
Copy link
Member

@harshad16 @DharmitD this may be relevant to you folks too

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👍

Thanks , i will pull this in dspo repo, as we use peak there as well.

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Mar 6, 2023

/approve

Merging this since it just adds local repos that ODH controls in the event we need to update the dependent frameworks

@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit f1d6262 into opendatahub-io:master Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants