Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Remove the creation of the anonymous namespace #767

Merged

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Mar 28, 2023

Description

Removes the creation of the anonymous namespace from the odh-common manifests. This was originally implemented as a workaround to prevent any delays in the odh-operator startup when it would check for any anonymous namespace for kubeflow deployments

How Has This Been Tested?

Deployed manually

Merge criteria:

CI tests pass with no issues

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b85a313 into opendatahub-io:master Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants