Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add data-science-pipelines-operator label for DSPO manifests #784

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Apr 11, 2023

Description

If we do an oc get pods -l app.kubernetes.io/created-by=data-science-pipelines-operator after deploying DSP Operator, it won't return any pods, because only the DSPO deployment contains this label, the pods don't. Adding this label to the pods as well, so they could be filtered using the component name, that is, Data Science Pipelines Operator.

Also, renamed the component to respect name-prefix, to make the service and service monitor consistent with DSPO (refer opendatahub-io/data-science-pipelines-operator#76)

How Has This Been Tested?

  • Deploy a DSP Operator instance.
  • Try out oc get pods -l app.kubernetes.io/created-by=data-science-pipelines-operator in the same namespace where the operator is deployed. Make sure it displays DSPO pods.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks 👍

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants