Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Fix tag's names on notebooks imagestreams with better naming #785

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix tag's names on notebooks imagestreams with better naming #785

merged 1 commit into from
May 3, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Apr 12, 2023 •
edited
Loading

This PR fixes the tag names on notebook versions, for better presentation on the notebooks server UI.

Description

For example, instead of being py3.8-v2 which doesn't provide any useful information changed to 2023.1 which is the version of the notebook (the N version for example)

How Has This Been Tested?

  • Deploy ODH with enabled the notebook-images
  • Login to odh-dashboard and navigate into notebooks server spawner
  • Check the version name that has been changed

image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 removed the request for review from anishasthana April 12, 2023 11:53
@atheo89
Copy link
Member Author

atheo89 commented Apr 12, 2023

/test odh-manifests-e2e

2 similar comments
@harshad16
Copy link
Member

/test odh-manifests-e2e

@harshad16
Copy link
Member

/test odh-manifests-e2e

@VaishnaviHire
Copy link
Member

Test failed due to broken operator failures. I have fixed them here #787

@atheo89 atheo89 force-pushed the fix-notebooks-tag-name branch 2 times, most recently from 01930d4 to c2889b3 Compare April 18, 2023 07:19
@shalberd
Copy link
Contributor

/retest

@LaVLaS LaVLaS added this to the ODH 1.6.0 Release milestone May 1, 2023
@atheo89
Copy link
Member Author

atheo89 commented May 2, 2023

/test 411-odh-manifests-e2e

@atheo89
Copy link
Member Author

atheo89 commented May 2, 2023

/test odh-manifests-e2e

VaishnaviHire
VaishnaviHire approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaishnaviHire
Copy link
Member

@atheo89 Expected failure in tests due to outdated tags in test Notebooks.

You would need to update image values for all test Notebooks to match the new tags

@VaishnaviHire VaishnaviHire removed the lgtm label May 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023 •
edited
Loading

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/49-images c2889b3 link true /test 49-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VaishnaviHire
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 56a6763 into opendatahub-io:master May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved lgtm
Projects
None yet
Milestone
ODH 1.6.0 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@atheo89 @harshad16 @VaishnaviHire @shalberd @LaVLaS @openshift-merge-robot