Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add must-gather collection script for DSP #798

Merged
merged 3 commits into from
May 15, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Apr 26, 2023

Description

Adding a must-gather collection script for Data Science Pipelines Application instances.

How Has This Been Tested?

  • Retrieved this image from the CI build for this PR: quay.io/opendatahub/must-gather:pr-798
  • Used this image to run must-gather on a cluster with DSP Operator and Application installed:
    oc adm must-gather --image=quay.io/opendatahub/must-gather:pr-798

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@VaishnaviHire
Copy link
Member

/retest

@DharmitD
Copy link
Member Author

DharmitD commented May 9, 2023

/test odh-manifests-e2e

2 similar comments
@DharmitD
Copy link
Member Author

DharmitD commented May 9, 2023

/test odh-manifests-e2e

@DharmitD
Copy link
Member Author

DharmitD commented May 9, 2023

/test odh-manifests-e2e

@VaishnaviHire
Copy link
Member

@DharmitD PR needs a rebase

@DharmitD
Copy link
Member Author

DharmitD commented May 9, 2023

/test 411-odh-manifests-e2e

@HumairAK
Copy link
Contributor

/lgtm

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DharmitD
Copy link
Member Author

/retest

1 similar comment
@DharmitD
Copy link
Member Author

/retest

@DharmitD
Copy link
Member Author

/retest-required

@DharmitD
Copy link
Member Author

/retest

1 similar comment
@DharmitD
Copy link
Member Author

/retest

@VaishnaviHire
Copy link
Member

/test all

1 similar comment
@DharmitD
Copy link
Member Author

/test all

@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

3 similar comments
@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2023

@DharmitD: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odh-manifests-e2e 3249cd5 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LaVLaS
Copy link
Contributor

LaVLaS commented May 15, 2023

I am manually merging this since this change does not affect the ODH deployment and the CI test failure is affecting all PRs

@LaVLaS LaVLaS merged commit 4c33bb2 into opendatahub-io:master May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants