Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Use tagged version of the CodeFlare operator #817

Merged

Conversation

anishasthana
Copy link
Member

@anishasthana anishasthana commented May 16, 2023

The reason for this is that the 0.0.2 release for the CodeFlare operator is broken -- we had a 0.0.3 release PR merged into community operators but it hasn't come out yet. We're waiting on the catalog to be updated but community operators has had some delays (on the order of days/weeks) for updates recently.

cc @DharmitD @Jooho @MichaelClifford

@LaVLaS
Copy link
Contributor

LaVLaS commented May 16, 2023

/hold

@anishasthana Can you provide a link to an issue or discussion on why this needs to be set to Manual approval

@openshift-ci openshift-ci bot added the do-not-merge/hold Hold off on merging (provide reason in comment) label May 16, 2023
@anishasthana
Copy link
Member Author

The reason for this is that the 0.0.2 release for the CodeFlare operator is broken -- we had a 0.0.3 release PR merged into community operators but it hasn't come out yet. We're waiting on the catalog to be updated but community operators has had some delays (on the order of days/weeks) for updates recently.

@LaVLaS
Copy link
Contributor

LaVLaS commented May 16, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Hold off on merging (provide reason in comment) label May 16, 2023
@anishasthana anishasthana force-pushed the update_codeflare_test branch 2 times, most recently from a64074b to 7ef2e3b Compare May 16, 2023 20:36
@Jooho
Copy link
Contributor

Jooho commented May 17, 2023

@anishasthana This still failed with 2 components

✘ FAILURE after 1209.330s: operator-tests/odh-manifests/basictests/codeflare-stack.sh:21: executing 'oc get pod -n opendatahub |grep mcad-controller | awk '{print $2}'' expecting any result and text '1/1'; re-trying every 10s until completion or 1200.000s: the command timed out

✘ FAILURE after 1201.886s: operator-tests/odh-manifests/basictests/ray.sh:40: executing 'oc logs ray-simple-test-5bd7ccdc6d-vj9rs | grep 'Simple tests passed'' expecting any result and text 'Simple tests passed'; re-trying every 10s until completion or 1200.000s: the command timed out

/root/peak/operator-tests/odh-manifests/basictests/codeflare-stack.sh
/root/peak/operator-tests/odh-manifests/basictests/ray.sh

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Copy link
Member Author

/retest

@jbusche
Copy link
Contributor

jbusche commented May 18, 2023

/lgtm

Copy link
Contributor

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaVLaS
Copy link
Contributor

LaVLaS commented May 18, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbusche, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0d02c23 into opendatahub-io:master May 18, 2023
@anishasthana anishasthana deleted the update_codeflare_test branch May 18, 2023 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants