Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add TrustyAI operator to ODH #864

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Conversation

RobGeada
Copy link
Contributor

@RobGeada RobGeada commented Jul 5, 2023

Description

  • Adds TrustyAI Operator to manifests
  • Removes TrustyAI-Service from manifests
  • Changes TrustyAI tests from service-based to operator-based

How Has This Been Tested?

  • Extensively tested via TrustyAI's CI; the test scripts here are modifications of our upstream CI
  • Tested via the UI team during their development of the TrustyAI dashboard

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

tests/resources/trustyai/trustyai_crd.yaml Outdated Show resolved Hide resolved
trustyai-service-operator/README.md Show resolved Hide resolved
trustyai-service-operator/manager/kustomization.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jul 7, 2023
@RobGeada
Copy link
Contributor Author

Note: we need to:

  • Clean up the operator manifests
  • Set a fixed service-image to align with odh-versioned images

@ruivieira
Copy link
Member

Note: we need to:

* Clean up the operator manifests

* Set a fixed service-image to align with odh-versioned images

Addressed in:

@LaVLaS
Copy link
Contributor

LaVLaS commented Jul 13, 2023

/retest

@LaVLaS
Copy link
Contributor

LaVLaS commented Jul 15, 2023

/retest

@RobGeada Can you add an OWNERS file so that the tide plugin knows who to ping for reviews.

Also, the openshift-ci system is still experiencing issues so we'll auto-merge this once the openshfit-ci issues are resolved

@RobGeada
Copy link
Contributor Author

/retest

@RobGeada Can you add an OWNERS file so that the tide plugin knows who to ping for reviews.

Also, the openshift-ci system is still experiencing issues so we'll auto-merge this once the openshfit-ci issues are resolved

The OWNERS file is here

@openshift-ci openshift-ci bot added the lgtm label Jul 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielezonca, ruivieira
Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS
Copy link
Contributor

LaVLaS commented Jul 18, 2023

The openshift-ci issues may still be affecting ocp 4.12 test runs. If the OCP 4.11 test run succeeds without any errors in our CI test then I'll admin override the merge

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

@RobGeada: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odh-manifests-e2e a6746e5 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LaVLaS
Copy link
Contributor

LaVLaS commented Jul 19, 2023

OCP 4.12 failed with the same known issue that is blocking the installation of any OLM operators on the cluster.
Since the OCP4.11 test ran without issue and the OCP 4.12 issue is outside of our control, I am merging this. The OCP 4.12 failure should be resolved later this week

@LaVLaS LaVLaS merged commit da017b2 into opendatahub-io:master Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants