Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Test kserve with updated Operator #876

Merged

Conversation

VaishnaviHire
Copy link
Member

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Jooho and others added 5 commits July 5, 2023 16:46
fix rhods-9627

Signed-off-by: jooho <jlee@redhat.com>
Update folder structure and KServe fork url

Pre-build KServe manifests to avoid issues with kfctl

Change the webhook certificates

Add runtime field to example InferenceService

fix minor issues

fix labels

no cert-manager

no certmanager

Use images from quay.io/opendatahub version 0.10.2

Fetch manifests from opendatahub-io/kserve

Revert back to assembled manifests KServe manifests using `kustomize` directly

Remove istio-cni env variable in controller

Simplify folder structure

Use release-0.10 branch to generate built yaml

Fix configuration params
@VaishnaviHire VaishnaviHire requested review from etirelli and removed request for danielezonca and LaVLaS July 14, 2023 13:47
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdtsw
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire VaishnaviHire merged commit 763fb7a into opendatahub-io:feature-rearchitecture Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants