-
Notifications
You must be signed in to change notification settings - Fork 211
Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow #900
Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow #900
Conversation
/lgtm |
/retest-required |
Ready for Review and Merge. |
/retest-required |
1 similar comment
/retest-required |
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
1 similar comment
/retest-required |
The e2e tests are failing, as the odh-dashboard part of e2e, uses ods-ci for verifying the notebook workflow. For this current PR. the reason to get this merged, is as the notebook-controller previous version v1.7.0-1 would cause issue with odh-dashboard latest master |
@harshad16 We will need to resolve this test failure in this PR since their appears to be an issue around the test that verifies the functionality between dashboard and notebook-controller |
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS, VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow
Description
The tag v1.7.0-2 of odh/kubeflow contains fixes.
Details available on release notes:
https://github.com/opendatahub-io/kubeflow/releases/tag/v1.7.0-2
Fixes: opendatahub-io/odh-dashboard#1619
How Has This Been Tested?
Deploy on an ODH cluster.
And execute a notebook to test this behaviour.
Merge criteria: