Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Ensure odh-model-controller compatibility with kserve deployment mode #918

Conversation

VedantMahabaleshwarkar
Copy link
Contributor

@VedantMahabaleshwarkar VedantMahabaleshwarkar commented Aug 17, 2023

Odh-model-controller was recently configured to add reconciliation logic for the Kserve Inferencing Stack. This PR makes compatibility related changes to the odh-model-controller manifests to ensure the controller does not break on unexpected conditions.

Description

  • Manually set kserve-enabled=false for the odh-model-controller deployment when used with modelmesh.
  • Add the updated role manifests as the new controller image expects these permissions (even though they are not used in this case)
  • Manually add the CRDs for Telemetries and PeerAuthentications. These are expected to already exist when used with kserve. However they are not expected to be installed when used with modelmesh. Since the controller logic expects the CRDs to be installed we manually add them to the manifests here.

How Has This Been Tested?

  • Install Opendatahub operator from the fast channel
  • Add the following to the DSCInitialization CR as follows manifestsUri: 'https://github.com/VedantMahabaleshwarkar/odh-manifests/tarball/disable-kserve-for-mm'
  • Create a DataScienceCluster CR with only modelmeshserving.enabled=true
  • Test the creation of a onnx isvc

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Jooho
Copy link
Contributor

Jooho commented Aug 17, 2023

/lgtm

@heyselbi
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

@VedantMahabaleshwarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-odh-manifests-e2e 5aafec0 link true /test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e 5aafec0 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

add updated rbac to modelmesh odh-model-controller

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

add peerauth and telemetry crd since controller image expects it

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>

add kustomization file

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

New changes are detected. LGTM label has been removed.

@taneem-ibrahim
Copy link

The modelmesh tests can be ignored based on @VedantMahabaleshwarkar retesting .

@taneem-ibrahim taneem-ibrahim merged commit 0bb56f5 into opendatahub-io:master Aug 17, 2023
3 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants