-
Notifications
You must be signed in to change notification settings - Fork 212
Ensure odh-model-controller compatibility with kserve deployment mode #918
Ensure odh-model-controller compatibility with kserve deployment mode #918
Conversation
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heyselbi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@VedantMahabaleshwarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> add updated rbac to modelmesh odh-model-controller Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> add peerauth and telemetry crd since controller image expects it Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> add kustomization file Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
5aafec0
to
62a39dc
Compare
New changes are detected. LGTM label has been removed. |
The modelmesh tests can be ignored based on @VedantMahabaleshwarkar retesting . |
Odh-model-controller was recently configured to add reconciliation logic for the Kserve Inferencing Stack. This PR makes compatibility related changes to the odh-model-controller manifests to ensure the controller does not break on unexpected conditions.
Description
kserve-enabled=false
for the odh-model-controller deployment when used with modelmesh.role
manifests as the new controller image expects these permissions (even though they are not used in this case)Telemetries
andPeerAuthentications
. These are expected to already exist when used withkserve
. However they are not expected to be installed when used withmodelmesh
. Since the controller logic expects the CRDs to be installed we manually add them to the manifests here.How Has This Been Tested?
fast
channelDSCInitialization
CR as followsmanifestsUri: 'https://github.com/VedantMahabaleshwarkar/odh-manifests/tarball/disable-kserve-for-mm'
DataScienceCluster
CR with onlymodelmeshserving.enabled=true
Merge criteria: