Add NIM flag logic

[trujillm]

Add NIM flag logic

Description

This will get the nim flag state of removed or managed from params.env and add to the environment variables for odh-model-controller to be utilize

How Has This Been Tested?

Unit tests

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Hi @trujillm. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[trujillm]

@spolti do you know if I need to change something for the image tag failure?

[israel-hdez]

Please, change the target branch to incubating.
The main branch is now a stable/downstream branch.

[zdtsw]

so in opendatahub-io/opendatahub-operator#1330, if not specify nim-state in DSC, it should pass down "managed" as default.
but here, if not get value from Operator, the default is removed.
isnt that inconsistent?
if the requirement from UX is, unless user explicitly set "removed" in DSC, then it is always "managed", then it should be nim-state=managed here, right?
in reality, it does not matter managed/remove/ "" in params.env since it will always be overrwritten by Operator. But if run odh-model-controller without Operator, then set "removed" here is different than "managed" also cause confusion in the code.

[trujillm]

@zdtsw I think the intent here was to add removed explicitly as a safety in case someone ever decides to change in params.env without taking modlemesh into consideration.

[Jooho]

/retest

[israel-hdez]

@trujillm I reviewed the commit and it is OK to me. Just, please, rebase on top of incubation to bring only your changes.

[israel-hdez]

@trujillm may you rebase your PR on incubation?
Looks like you did your changes on top of the main branch, which is no longer our default branch, and there are a lot of changes because of the different base branch.

[trujillm]

@israel-hdez I believe I have corrected please verify and let me know if you need anything else from my side

[israel-hdez]

/ok-to-test

[israel-hdez]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti, trujillm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [israel-hdez,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment