Oneroute

[VedantMahabaleshwarkar]

Description

This PR modifies odh-model-controller as follows :

• 1 route will be created PER namespace for accessing all models in the namespace.
• Route creation/deletion is controller by creation/deletion of ServingRuntimes instead of InferenceServices
• Old routes will automatically not be deleted if they were created BEFORE the upgrade (one routes being the ones created per inferenceservice)
• Old route will be deleted if the associated inferenceservice is deleted (same behavior as before)

Testing

• Deploy existing production RHODS
• Deploy a model server and isvc and confirm 1 route is created for the isvc
• Uninstall RHODS (do not delete the model server and isvc)
• Install rhods using http://quay.io/vedantm/rhods-operator-live-catalog:1.28.0-oneroute
• Navigate to the NS with the model server
• Verify 2 routes exist (old route + new -model-route)
• Create a NEW isvc with a different name, verify this new isvc does not get it's own route
• Delete original isvc, verify if the route associated with the isvc got deleted but the new -model-route still exists.
• Delete model server and verify the associated route is deleted.

JIRA: https://issues.redhat.com/browse/RHODS-5888
Doc: https://docs.google.com/document/d/1PCL3wgkk_OSY9Km9vOt2kZ4t6lEtitj223dYea-Uuk4/edit#heading=h.w5e37xee1yqq
ADR : TBD

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VedantMahabaleshwarkar]

PR is ready for review. However the merge for this PR should happen after kserve/modelmesh#90 has made it's way downstream

[VedantMahabaleshwarkar]

/test all

[openshift-ci]

@VedantMahabaleshwarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	9a9d4d9	link	true	/test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spolti]

@VedantMahabaleshwarkar is this still valid?

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[israel-hdez]

@spolti not valid, anymore. Let's close this.

[spolti]

/close