Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions #15

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update versions #15

merged 1 commit into from
Sep 18, 2023

Conversation

vaibhavjainwiz
Copy link
Member

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

VedantMahabaleshwarkar
VedantMahabaleshwarkar approved these changes Sep 14, 2023
View reviewed changes
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaibhavjainwiz, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link

Jooho commented Sep 14, 2023

/retest

1 similar comment
@Jooho
Copy link

Jooho commented Sep 17, 2023

/retest

@vaibhavjainwiz
Copy link
Member Author

/test fvt

@Jooho
Copy link

Jooho commented Sep 18, 2023

@vaibhavjainwiz The fvt test will be failed because it uses the wrong modelmesh-serving-develop image. This pr will solve the issue.: openshift/release#43449

@Jooho
Copy link

Jooho commented Sep 18, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

@vaibhavjainwiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fvt 9b7fcd7 link true /test fvt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jooho
Copy link

Jooho commented Sep 18, 2023

/retest

@vaibhavjainwiz
Update versions
c448eea 
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
Update version

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
Update version

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Sep 18, 2023
@Jooho
Copy link

Jooho commented Sep 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit b5bb894 into release-0.11 Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VedantMahabaleshwarkar VedantMahabaleshwarkar VedantMahabaleshwarkar approved these changes

@israel-hdez israel-hdez Awaiting requested review from israel-hdez

Assignees

@Jooho Jooho

@VedantMahabaleshwarkar VedantMahabaleshwarkar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaibhavjainwiz @Jooho @VedantMahabaleshwarkar @openshift-merge-robot