Add tests #3
Merged
Add tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filters need to be reviewed after this PR is merged I think, as the fields will change. |
maudetes
reviewed
Jan 19, 2022
maudetes
reviewed
Jan 25, 2022
| def create_index(self) -> None: | ||
| pass | ||
| @pytest.fixture(autouse=True) | ||
| def db(search_client): |
There was a problem hiding this comment.
Does it means that you're deleting dev indices when you run the tests? We could use index names with test in it?
Add tests for the kafka consumer
maudetes
reviewed
Feb 2, 2022
maudetes
reviewed
Feb 3, 2022
Co-authored-by: maudetes <maudet.estelle@gmail.com>
maudetes
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix datagouv/data.gouv.fr#677
Fix datagouv/data.gouv.fr#676