Implement allocation action which can be used in index state management #106

dabr-grapeup · 2019-10-30T07:55:27Z

Issue #, if available: #103

Description of changes: Implemented Allocation action which can be used in ILM policy, action sets allocation properties to given index settings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dbbaughe · 2019-11-01T23:56:16Z

Hi @dabr-grapeup,

Thanks for the PR!

I'm currently looking into an easy way to include multi-node integration tests in index management since we'll need it for this PR. Will look over the rest of the PR over the next couple days too.

arnitolog · 2019-12-24T15:21:47Z

@dbbaughe have you had a chance to review this PR? I look forward to this action.

dbbaughe · 2020-02-05T21:45:49Z

Hey @dabr-grapeup and @arnitolog,

We have one main blocker for this PR which is the testing part. We need to setup our integration tests to run on a multi-node setup so we can accurately test the allocation part. If someone can pick that up it would be great, otherwise it will have to wait until we can allocate resources to that task.

Thanks,
Drew

dbbaughe · 2020-07-29T00:55:10Z

Hi @dabr-grapeup,

If you have the time, this PR has been unblocked by
#254
#256

So we have a way to run multi node tests now. What we need to do is add an integration test for the Allocation action that successfully migrates the shards of the index to a different node and I believe you can use the node name or number (can't remember off top of my head.. I think it's one of those) to control the shard allocation. And we need the test to only conditionally run when it's being run in multi-node configuration which we can check with the number of nodes property.

If you get the chance to look this over, great! If not I'll try to pick it up shortly and write the test.

jgprogramming · 2020-07-30T10:56:20Z

Hey @dbbaughe , I'm working on those tests, they should be ready tomorrow.

…rch/index-management into opendistro-for-elasticsearch#103-allocation � Conflicts: � src/main/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/model/action/ActionConfig.kt � src/test/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/TestHelpers.kt � src/test/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/model/ActionConfigTests.kt

codecov · 2020-07-30T13:05:07Z

Codecov Report

Merging #106 into master will increase coverage by 0.14%.
The diff coverage is 75.90%.

@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
+ Coverage     71.46%   71.60%   +0.14%     
- Complexity      635      652      +17     
============================================
  Files            86       89       +3     
  Lines          3690     3772      +82     
  Branches        610      619       +9     
============================================
+ Hits           2637     2701      +64     
- Misses          736      745       +9     
- Partials        317      326       +9

Impacted Files	Coverage Δ	Complexity Δ
.../indexstatemanagement/model/action/ActionConfig.kt	`94.00% <66.66%> (+0.25%)`	`8.00 <0.00> (ø)`
...emanagement/model/action/AllocationActionConfig.kt	`75.00% <75.00%> (ø)`	`10.00 <10.00> (?)`
...anagement/step/allocation/AttemptAllocationStep.kt	`76.47% <76.47%> (ø)`	`5.00 <5.00> (?)`
...ch/indexstatemanagement/action/AllocationAction.kt	`83.33% <83.33%> (ø)`	`2.00 <2.00> (?)`
...ticsearch/indexstatemanagement/model/Transition.kt	`80.39% <0.00%> (-5.89%)`	`5.00% <0.00%> (ø%)`
...exstatemanagement/model/destination/Destination.kt	`44.11% <0.00%> (-4.42%)`	`7.00% <0.00%> (ø%)`
...ndexstatemanagement/IndexStateManagementIndices.kt	`64.91% <0.00%> (+3.50%)`	`10.00% <0.00%> (ø%)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef5b65...ea1d2d7. Read the comment docs.

src/main/resources/mappings/opendistro-ism-config.json

...kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/action/AllocationAction.kt

...mazon/opendistroforelasticsearch/indexstatemanagement/model/action/AllocationActionConfig.kt

...zon/opendistroforelasticsearch/indexstatemanagement/step/allocation/AttemptAllocationStep.kt

dbbaughe · 2020-07-31T00:18:21Z

...zon/opendistroforelasticsearch/indexstatemanagement/step/allocation/AttemptAllocationStep.kt

+
+    private fun buildSettings(): Settings {
+        val builder = Settings.builder()
+        config.require.forEach { (key, value) -> builder.put(SETTINGS_PREFIX + AllocationActionConfig.REQUIRE + "." + key, value) }


Can the key values be absolutely anything? Or should we have some validation on them in the parser? i.e. can you have something like "index.routing.allocation._?__": " " or will it throw an exception?

While it is not possible to configure key like "index.routing.allocation._..__": " " it is possible to configure "index.routing.allocation._._._._.": " " which is equally useless. As far as I know elastic doesn't provide one regex that we can match to so I've added a test that shows that any invalid key will result in a failed policy.

...tlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/action/AllocationActionIT.kt

dbbaughe · 2020-07-31T00:23:54Z

...tlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/action/AllocationActionIT.kt

+        updateManagedIndexConfigStartTime(managedIndexConfig)
+
+        waitFor {
+            assertEquals("integTest-1", getIndexShardNodes(indexName)[0])


It's possible this started out on integTest-1 to begin with. I think we need to get the current value of the node its on and then migrate it to the other one and assert it or perhaps have two Allocation actions on the policy that swap it between both nodes and then add another updateManagedIndexConfigStartTime and assertion to show it was on both when required.

Done, I've added a check to see on which node index is allocated. I think it's a cleaner solution than allocating multiple times.

dbbaughe · 2020-07-31T00:24:16Z

...tlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/action/AllocationActionIT.kt

+        updateManagedIndexConfigStartTime(managedIndexConfig)
+
+        waitFor {
+            assertNotEquals("integTest-0", getIndexShardNodes(indexName)[0])


Same as above, it's possible this was not on integTest-0 to begin with

dbbaughe · 2020-07-31T00:24:32Z

...tlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/action/AllocationActionIT.kt

+        updateManagedIndexConfigStartTime(managedIndexConfig)
+
+        waitFor {
+            assertEquals("integTest-1", getIndexShardNodes(indexName)[0])


Same as above

dbbaughe · 2020-07-31T00:34:07Z

...zon/opendistroforelasticsearch/indexstatemanagement/step/allocation/AttemptAllocationStep.kt

+import org.elasticsearch.cluster.service.ClusterService
+import org.elasticsearch.common.settings.Settings
+
+class AttemptAllocationStep(


Also saw the mappings had a wait_for which I'm assuming is a flag to optionally wait for the shards to finish migrating to their respective filtered nodes, but I don't see it used. Are we skipping it for the first implementation? That's fine if so, otherwise we would need another step (WaitForAllocation or something) that would periodically check the shard locations.

That's correct, it's a placeholder for future step.

jgprogramming · 2020-08-03T11:32:47Z

@dbbaughe Thanks for your comments, let me know if there's anything else.

dbbaughe

Thanks!

bowenlan-amzn · 2020-08-03T16:40:31Z

Thanks!

opendistro-for-elasticsearch#103 Attempt allocation implementation

809e349

dbbaughe mentioned this pull request Feb 5, 2020

Multi-node integration tests #145

Closed

praveensameneni added the enhancement An improvement on the existing feature’s functionalities label Jun 9, 2020

anirudha changed the title ~~#103 Attempt allocation implementation~~ Implemented Allocation action which can be used in index life cycle management Jul 8, 2020

anirudha changed the title ~~Implemented Allocation action which can be used in index life cycle management~~ Implemented allocation action which can be used in index life cycle management Jul 8, 2020

Jakub Grzeska added 3 commits July 30, 2020 14:14

add allocation multinode tests

ef608b9

add spacing to conditions

0be181b

dbbaughe reviewed Jul 31, 2020

View reviewed changes

Jakub Grzeska added 2 commits August 3, 2020 10:31

add missing license

b0ebf1c

verify node allocation during tests

ea1d2d7

dbbaughe approved these changes Aug 3, 2020

View reviewed changes

bowenlan-amzn approved these changes Aug 3, 2020

View reviewed changes

dbbaughe merged commit 3a967aa into opendistro-for-elasticsearch:master Aug 3, 2020

dbbaughe changed the title ~~Implemented allocation action which can be used in index life cycle management~~ Implemented allocation action which can be used in index state management Aug 19, 2020

jcgraybill changed the title ~~Implemented allocation action which can be used in index state management~~ Implement allocation action which can be used in index state management Oct 1, 2020

samling mentioned this pull request Jan 20, 2021

Cannot create policy after upgrading to v1.12 #388

Open

adityaj1107 mentioned this pull request Jun 3, 2021

Cannot create policy after upgrading to v1.12 opensearch-project/index-management#58

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement allocation action which can be used in index state management #106

Implement allocation action which can be used in index state management #106

dabr-grapeup commented Oct 30, 2019

dbbaughe commented Nov 1, 2019

arnitolog commented Dec 24, 2019 •

edited

Loading

dbbaughe commented Feb 5, 2020

dbbaughe commented Jul 29, 2020

jgprogramming commented Jul 30, 2020

codecov bot commented Jul 30, 2020 •

edited

Loading

dbbaughe Jul 31, 2020

jgprogramming Aug 3, 2020

dbbaughe Jul 31, 2020

jgprogramming Aug 3, 2020

dbbaughe Jul 31, 2020 •

edited

Loading

dbbaughe Jul 31, 2020

dbbaughe Jul 31, 2020

jgprogramming Aug 3, 2020

jgprogramming commented Aug 3, 2020

dbbaughe left a comment

bowenlan-amzn commented Aug 3, 2020

Implement allocation action which can be used in index state management #106

Implement allocation action which can be used in index state management #106

Conversation

dabr-grapeup commented Oct 30, 2019

dbbaughe commented Nov 1, 2019

arnitolog commented Dec 24, 2019 • edited Loading

dbbaughe commented Feb 5, 2020

dbbaughe commented Jul 29, 2020

jgprogramming commented Jul 30, 2020

codecov bot commented Jul 30, 2020 • edited Loading

Codecov Report

dbbaughe Jul 31, 2020

Choose a reason for hiding this comment

jgprogramming Aug 3, 2020

Choose a reason for hiding this comment

dbbaughe Jul 31, 2020

Choose a reason for hiding this comment

jgprogramming Aug 3, 2020

Choose a reason for hiding this comment

dbbaughe Jul 31, 2020 • edited Loading

Choose a reason for hiding this comment

dbbaughe Jul 31, 2020

Choose a reason for hiding this comment

dbbaughe Jul 31, 2020

Choose a reason for hiding this comment

jgprogramming Aug 3, 2020

Choose a reason for hiding this comment

jgprogramming commented Aug 3, 2020

dbbaughe left a comment

Choose a reason for hiding this comment

bowenlan-amzn commented Aug 3, 2020

arnitolog commented Dec 24, 2019 •

edited

Loading

codecov bot commented Jul 30, 2020 •

edited

Loading

dbbaughe Jul 31, 2020 •

edited

Loading