This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Refactors files/classes to prepare for multiple features under the In… #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex Management suite
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
============================================
- Coverage 75.42% 75.37% -0.05%
+ Complexity 705 704 -1
============================================
Files 89 89
Lines 3914 3919 +5
Branches 627 625 -2
============================================
+ Hits 2952 2954 +2
- Misses 636 640 +4
+ Partials 326 325 -1
Continue to review full report at Codecov.
|
dbbaughe
commented
Aug 26, 2020
const val INDEX_STATE_MANAGEMENT_INDEX = ".opendistro-ism-config" | ||
const val INDEX_STATE_MANAGEMENT_JOB_TYPE = "opendistro-managed-index" | ||
const val INDEX_MANAGEMENT_INDEX = ".opendistro-ism-config" | ||
const val INDEX_MANAGEMENT_JOB_TYPE = "opendistro-index-management" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note: Job Scheduler only lets us specify one job type which is why we changed this to be more generic for the whole plugin. At the same time it does not actually use this so it's not that important.
...ndistroforelasticsearch/indexmanagement/indexstatemanagement/elasticapi/ElasticExtensions.kt
Outdated
Show resolved
Hide resolved
...endistroforelasticsearch/indexmanagement/indexstatemanagement/IndexStateManagementHistory.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/IndexManagementPlugin.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/IndexManagementIndices.kt
Outdated
Show resolved
Hide resolved
bowenlan-amzn
approved these changes
Aug 27, 2020
qreshi
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dex Management suite
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.