Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

actionify explain API #304

Merged
merged 1 commit into from
Oct 12, 2020
Merged

actionify explain API #304

merged 1 commit into from
Oct 12, 2020

Conversation

bowenlan-amzn
Copy link
Contributor

Issue #, if available:
#292

Description of changes:
actionify explain API, refactor our API code so we have an action name to each API

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #304 into master will increase coverage by 0.23%.
The diff coverage is 92.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
+ Coverage     74.90%   75.14%   +0.23%     
- Complexity      769      787      +18     
============================================
  Files           108      112       +4     
  Lines          4145     4200      +55     
  Branches        642      645       +3     
============================================
+ Hits           3105     3156      +51     
- Misses          700      702       +2     
- Partials        340      342       +2     
Impacted Files Coverage Δ Complexity Δ
...nagement/transport/action/explain/ExplainAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
...agement/transport/action/explain/ExplainRequest.kt 89.47% <89.47%> (ø) 7.00 <7.00> (?)
...transport/action/explain/TransportExplainAction.kt 90.32% <90.32%> (ø) 2.00 <2.00> (?)
...ticsearch/indexmanagement/IndexManagementPlugin.kt 91.30% <100.00%> (+0.12%) 9.00 <0.00> (ø)
...exstatemanagement/resthandler/RestExplainAction.kt 91.66% <100.00%> (-5.31%) 6.00 <0.00> (-1.00)
...gement/transport/action/explain/ExplainResponse.kt 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...anagement/indexstatemanagement/model/Transition.kt 82.35% <0.00%> (-3.93%) 5.00% <0.00%> (ø%)
...ndexstatemanagement/IndexStateManagementHistory.kt 75.96% <0.00%> (-1.93%) 27.00% <0.00%> (-1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421c3ef...c8f1abf. Read the comment docs.

@bowenlan-amzn bowenlan-amzn added the enhancement An improvement on the existing feature’s functionalities label Oct 9, 2020
import org.elasticsearch.common.xcontent.ToXContentObject
import org.elasticsearch.common.xcontent.XContentBuilder
import java.io.IOException
import java.util.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove wildcard import

@bowenlan-amzn bowenlan-amzn merged commit f8d90ea into opendistro-for-elasticsearch:master Oct 12, 2020
@bowenlan-amzn bowenlan-amzn deleted the add-explain-pr branch February 9, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement on the existing feature’s functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants