-
Notifications
You must be signed in to change notification settings - Fork 45
Adds all rollup REST APIs, updates mappings, adds test resources, ref… #320
Adds all rollup REST APIs, updates mappings, adds test resources, ref… #320
Conversation
…actors generic utils
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
============================================
- Coverage 73.90% 73.76% -0.14%
- Complexity 1016 1168 +152
============================================
Files 139 173 +34
Lines 5277 5894 +617
Branches 826 898 +72
============================================
+ Hits 3900 4348 +448
- Misses 951 1081 +130
- Partials 426 465 +39
Continue to review full report at Codecov.
|
...on/opendistroforelasticsearch/indexmanagement/rollup/action/explain/ExplainRollupResponse.kt
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/indexmanagement/rollup/action/start/TransportStartRollupAction.kt
Outdated
Show resolved
Hide resolved
...zon/opendistroforelasticsearch/indexmanagement/rollup/resthandler/RestExplainRollupAction.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/rollup/RollupRestTestCase.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/rollup/action/ActionTests.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/rollup/action/RequestTests.kt
Outdated
Show resolved
Hide resolved
}) | ||
} | ||
|
||
private fun updateRollupMetadata(rollup: Rollup, actionListener: ActionListener<AcknowledgedResponse>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed before, we wanted some way for the user to recover from a FAILED
metadata status. The state we want to get it into is RETRY
since we have logic for those cases in the RollupRunner
and RollupMetadataService
. If we want to use the _start
API as the mechanism for users retrying failed metadata cases, then we can add the logic here to update from FAILED
-> RETRY
.
This can be made in a separate PR, we'll just want to make sure that there is some mechanism for triggering a retry from the user. We can also review the retry workflow for rollup in general at that time, such as changing _stop
to not set to STOPPED
if it's in FAILED
state as well.
…actors generic utils
Issue #, if available:
Description of changes:
Adds all rollup REST APIs
Updates mappings
Adds test resources
Refactors generic utils
There are some tests that were removed as the runner logic doesn't exist yet, will add those back after
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.