Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fixes incorrect field in mappings check that ignores sub fields #343

Merged
merged 4 commits into from
Nov 18, 2020

Conversation

dbbaughe
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbbaughe dbbaughe requested review from thalurur and qreshi November 18, 2020 18:55
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #343 (f41b852) into master (b43b809) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #343      +/-   ##
============================================
+ Coverage     75.85%   75.88%   +0.02%     
- Complexity     1332     1333       +1     
============================================
  Files           182      182              
  Lines          6822     6822              
  Branches       1095     1095              
============================================
+ Hits           5175     5177       +2     
+ Misses         1053     1052       -1     
+ Partials        594      593       -1     
Impacted Files Coverage Δ Complexity Δ
...arch/indexmanagement/rollup/RollupMapperService.kt 59.45% <0.00%> (ø) 25.00 <0.00> (+1.00)
...orelasticsearch/indexmanagement/util/IndexUtils.kt 76.92% <ø> (ø) 1.00 <0.00> (ø)
...anagement/indexstatemanagement/model/Transition.kt 67.69% <0.00%> (+3.07%) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43b809...e94004a. Read the comment docs.

qreshi
qreshi previously approved these changes Nov 18, 2020
thalurur
thalurur previously approved these changes Nov 18, 2020
@dbbaughe dbbaughe dismissed stale reviews from thalurur and qreshi via e659000 November 18, 2020 20:24
@dbbaughe dbbaughe merged commit 0a9b4fb into opendistro-for-elasticsearch:master Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants