-
Notifications
You must be signed in to change notification settings - Fork 45
Introducing a new FieldCaps ActionFilter #345
Introducing a new FieldCaps ActionFilter #345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
============================================
- Coverage 75.54% 74.97% -0.58%
- Complexity 1333 1347 +14
============================================
Files 182 183 +1
Lines 6822 6962 +140
Branches 1095 1129 +34
============================================
+ Hits 5154 5220 +66
- Misses 1071 1142 +71
- Partials 597 600 +3
Continue to review full report at Codecov.
|
...com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/FieldCapsFilter.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/IndexManagementPlugin.kt
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/FieldCapsFilter.kt
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/FieldCapsFilter.kt
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/FieldCapsFilter.kt
Show resolved
Hide resolved
Mostly nits or small changes, can address now or later. Biggest thing is let's start adding some comments to explain the purpose of each part. Can be hard to try and just get a high level view of what's happening (or supposed to happen) as need to read through every function to see what's going on. (This applies to PRs @qreshi and I have too). This can also be done as a follow up though. |
Will do this as a follow up, will add for search interceptor as well in just one PR |
Issue #, if available:
N/A
Description of changes:
Add a field caps action filter to return only formatted fields for rollup indices
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.