This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix exception with Instant type when performing continuous rollup #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or rollup search request
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
============================================
- Coverage 76.28% 76.03% -0.26%
Complexity 1384 1384
============================================
Files 183 183
Lines 7022 7022
Branches 1143 1143
============================================
- Hits 5357 5339 -18
- Misses 1035 1056 +21
+ Partials 630 627 -3
Continue to review full report at Codecov.
|
dbbaughe
approved these changes
Jan 7, 2021
thalurur
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #364
Description of changes:
Passing in
Instantto theRangeQueryBuilderwhen creating search requests for continuous rollups leads tocan not write type [class java.time.Instant]exceptions. Converting Instant to epoch millis as Long to fix this issue.The problem was reproduced locally and confirmed that this change fixed continuous rollups and the target index contents were validated against the source index for consistency.
Some tests specifically validating continuous rollup output or search consistency should be added. If they aren't addressed here, they will be tracked as a follow-up item.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.