This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
new ISM template #383
Merged
bowenlan-amzn
merged 26 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:ismtemplate2
Jan 28, 2021
Merged
new ISM template #383
bowenlan-amzn
merged 26 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:ismtemplate2
Jan 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add filter by lastupdatetime, sort by priority logic
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
============================================
- Coverage 77.48% 77.31% -0.18%
- Complexity 1492 1513 +21
============================================
Files 194 197 +3
Lines 7552 7748 +196
Branches 1210 1250 +40
============================================
+ Hits 5852 5990 +138
- Misses 1041 1080 +39
- Partials 659 678 +19
Continue to review full report at Codecov.
|
thalurur
reviewed
Jan 21, 2021
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Outdated
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Outdated
Show resolved
Hide resolved
...exmanagement/indexstatemanagement/transport/action/indexpolicy/TransportIndexPolicyAction.kt
Outdated
Show resolved
Hide resolved
...exmanagement/indexstatemanagement/transport/action/indexpolicy/TransportIndexPolicyAction.kt
Outdated
Show resolved
Hide resolved
...exmanagement/indexstatemanagement/transport/action/indexpolicy/TransportIndexPolicyAction.kt
Outdated
Show resolved
Hide resolved
thalurur
previously approved these changes
Jan 26, 2021
dbbaughe
reviewed
Jan 26, 2021
.../amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/ISMTemplate.kt
Outdated
Show resolved
Hide resolved
...troforelasticsearch/indexmanagement/indexstatemanagement/resthandler/ISMTemplateRestAPIIT.kt
Show resolved
Hide resolved
...exmanagement/indexstatemanagement/transport/action/indexpolicy/TransportIndexPolicyAction.kt
Outdated
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/ISMTemplate.kt
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Show resolved
Hide resolved
...ndistroforelasticsearch/indexmanagement/indexstatemanagement/elasticapi/ElasticExtensions.kt
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
...otlin/com/amazon/opendistroforelasticsearch/indexmanagement/util/IndexManagementException.kt
Show resolved
Hide resolved
qreshi
reviewed
Jan 28, 2021
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Outdated
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ISMTemplateService.kt
Show resolved
Hide resolved
dbbaughe
approved these changes
Jan 28, 2021
qreshi
approved these changes
Jan 28, 2021
bowenlan-amzn
added
the
feature
A change that introduce a new unit of functionality of a software system that satisfies a requirem
label
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature
A change that introduce a new unit of functionality of a software system that satisfies a requirem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We are gonna remove policyID usage for security reason, so using index template to set policyID to manage index automatically will not be able anymore.
we add this ISM template to be the substitution for previous index template usage.
Bothered by a failing test which caused by Coordinator clear metadata which will be removed in next remove policyID PR, so comment out that test
Change Coordinator to implement ClusterStateListener but not LocalNodeMasterListener. If don't do this, I can see double logs. refer alerting change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.