-
Notifications
You must be signed in to change notification settings - Fork 45
Field cap fix #422
Field cap fix #422
Conversation
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
============================================
- Coverage 77.12% 76.81% -0.31%
+ Complexity 1550 1540 -10
============================================
Files 198 199 +1
Lines 8217 8325 +108
Branches 1317 1323 +6
============================================
+ Hits 6337 6395 +58
- Misses 1170 1230 +60
+ Partials 710 700 -10
Continue to review full report at Codecov.
|
...tlin/com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/SerDeTests.kt
Show resolved
Hide resolved
...tlin/com/amazon/opendistroforelasticsearch/indexmanagement/rollup/settings/RollupSettings.kt
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/indexmanagement/rollup/actionfilter/FieldCapsFilter.kt
Show resolved
Hide resolved
* TODO: When/if FieldCapabilitiesResponse and other subclasses package private constructors are elevated to public we can remove this logic. | ||
*/ | ||
|
||
class ISMFieldCapabilitiesIndexResponse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we split these into individual files with filenames as their classnames?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think its better to contain these classes in a single file to keep the code contained at one place.
Issue #, if available:
#418
#424
Description of changes:
Update
FieldCaps
interception to support remote cluster indices, and also supporting both merged and unmerged response rewriting of FieldCapsResponse.By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.