This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support Struct Data Query In SQL/PPL #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1018 +/- ##
==========================================
Coverage 99.87% 99.87%
- Complexity 2406 2410 +4
==========================================
Files 234 234
Lines 5526 5540 +14
Branches 357 358 +1
==========================================
+ Hits 5519 5533 +14
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
dai-chen
approved these changes
Jan 29, 2021
| @@ -49,4 +69,44 @@ public ExprType type() { | |||
| public String toString() { | |||
| return attr; | |||
| } | |||
|
|
|||
| /** | |||
| * Resolve the ExprValue from {@link ExprTupleValue} using paths.* | |||
There was a problem hiding this comment.
np: is paths.* intentional or a typo?
| return resolve(value, paths); | ||
| } | ||
|
|
||
| private ExprValue resolve(ExprValue value, List<String> paths) { |
There was a problem hiding this comment.
Can this / do we need to handle project.year is another object field? ex. project.year.month
There was a problem hiding this comment.
Good point. add more cases in doc and UT.
We don't expect object filed name include "." which is not supported now.
chloe-zh
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #795
Description of changes:
To Reviewer
There are 2 ITs in legacy engine have been disabled.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.