Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Only keep the first element of multivalue field response. #1026

Merged
merged 11 commits into from
Feb 3, 2021

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Feb 2, 2021

Issue #, if available: #1017

Description of changes:

  1. Only keep the first element of multivalue field response. https://github.com/penghuo/sql/blob/issue-1017/docs/experiment/ppl/general/datatypes.rst#example-3-selecting-field-of-array-value

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from dai-chen and chloe-zh February 2, 2021 03:56
@penghuo penghuo self-assigned this Feb 2, 2021
@penghuo penghuo added SQL enhancement New feature or request and removed SQL labels Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1026 (3276e77) into develop (1dbf244) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1026      +/-   ##
=============================================
- Coverage      99.87%   99.87%   -0.01%     
- Complexity      2416     2431      +15     
=============================================
  Files            234      236       +2     
  Lines           5547     5535      -12     
  Branches         359      332      -27     
=============================================
- Hits            5540     5528      -12     
  Misses             5        5              
  Partials           2        2              
Impacted Files Coverage Δ Complexity Δ
...ticsearch/data/utils/ElasticsearchJsonContent.java 100.00% <100.00%> (ø) 20.00 <20.00> (?)
...ch/sql/elasticsearch/data/utils/ObjectContent.java 100.00% <100.00%> (ø) 19.00 <19.00> (?)
...arch/data/value/ElasticsearchExprValueFactory.java 100.00% <100.00%> (ø) 36.00 <30.00> (-24.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbf244...3276e77. Read the comment docs.

@penghuo penghuo marked this pull request as ready for review February 2, 2021 16:57
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit e67522a into opendistro-for-elasticsearch:develop Feb 3, 2021
@penghuo penghuo deleted the issue-1017 branch February 3, 2021 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants