Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix Round fix issue when input is negative and end with .5 #914

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

harold-wang
Copy link
Contributor

*Issue #908
Round function did not round negative number correctly in case input is negative and end with .5.
issue: Round(-3.5) = 3.0 instead of 4.0

Description of changes:
Change Round(double) to Round(double, 0)

Test: IT added and 100% pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #914 (5635846) into develop (d170da3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #914   +/-   ##
==========================================
  Coverage      99.85%   99.85%           
  Complexity      2149     2149           
==========================================
  Files            216      216           
  Lines           4851     4852    +1     
  Branches         323      323           
==========================================
+ Hits            4844     4845    +1     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø) 122.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d170da3...5635846. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@harold-wang harold-wang merged commit 262330d into opendistro-for-elasticsearch:develop Dec 11, 2020
penghuo pushed a commit that referenced this pull request Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants