Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

docs: comment on EDXAPP_PRIVATE_REQUIREMENTS #6991

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Aug 18, 2023

Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS contains edx.org specific details, which is not ideal. The plan is to ultimately retire this repo according to the DEPR: openedx/public-engineering#51

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS
contains edx.org specific details, which is not ideal. The plan
is to ultimately retire this repo according to the DEPR:
openedx/public-engineering#51
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, but looks good.

Co-authored-by: Tim McCormack <tmccormack@edx.org>
@robrap robrap merged commit c3ea23e into master Aug 21, 2023
@robrap robrap deleted the robrap/add-private-requirement-docs branch August 21, 2023 20:29
jdmulloy pushed a commit that referenced this pull request Sep 14, 2023
Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS
contains edx.org specific details, which is not ideal. The plan
is to ultimately retire this repo according to the DEPR:
openedx/public-engineering#51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants