Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: Set Datadog resource name to just the handler in all apps #7175

Merged
merged 1 commit into from
May 6, 2024

Conversation

timmc-edx
Copy link
Contributor

This switches us from method+urlpattern resource naming (e.g. GET ^/) to using handler (e.g. lms.djangoapps.branding.views.index).

This is applied to the root span as the resource_name tag. As method and urlpattern are available on the root span as http.method and http.route but there doesn't seem to be any other way to get the handler info, this is our only option for ensuring that the handler will be available as a tag (without having to parse after the fact or write more custom code.)

Part of edx/edx-arch-experiments#620

Configuration Pull Request

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.
  • Think about how this change will affect Open edX operators and update the wiki page for the next Open edX release if needed

This switches us from method+urlpattern resource naming (e.g. `GET ^/`)
to using handler (e.g. `lms.djangoapps.branding.views.index`).

This is applied to the root span as the `resource_name` tag. As method and
urlpattern are available on the root span as `http.method` and `http.route`
but there doesn't seem to be any other way to get the handler info, this is
our only option for ensuring that the handler will be available as a tag
(without having to parse after the fact or write more custom code.)

Part of edx/edx-arch-experiments#620
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timmc-edx timmc-edx merged commit c8aa592 into master May 6, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/dd-resource-name branch May 6, 2024 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants