-
Notifications
You must be signed in to change notification settings - Fork 132
Fix github url strings (org edx -> openedx) #1358
Conversation
1a63747
to
7f61fca
Compare
@pomegranited - any thoughts on why this failed with |
pylintrc
Outdated
load-plugins=pylint.extensions.redefined_variable_type | ||
ignore = | ||
persistent = yes | ||
load-plugins = edx_lint.pylint,pylint_django,pylint_celery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina This is the line that's causing your edx_lint
error. Bad news? The pylint==2.4.4 constraint is so old, that we have to go back to edx-lint==1.5.2 to support it, and that version of edx-lint
doesn't have a pylint plugin yet.
Worse news? The edx_lint
error reported is at the vanguard of a whole army of pylint
errors that arise from the other changes in this file.
So you can either remove the alterations to this pylintrc
file from this PR, or put this PR on hold until I upgrade pylint
and fix all the quality issues that arise. I'll put a task in my next sprint to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! I ran edx_lint
on every repo because all generated versions of the file have an edx/
url defined. I just checked and the (probably very-old) version of pylintrc on this repo does'n actually have the string, so I can revert this change.
I don't know exactly how valuable it would be to update pylint & use the standard generated pylint file 🤷🏻♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah me neither really.. but eventually the old pylint will bite us. I'll do it as part of the dependabot updates that are pending here, and at least we'll get those in too.
There's likely to be similar issues on the other edx-analytics repos, so feel free to ping me on those if you encounter them?
Thanks @sarina !
7f61fca
to
63b5180
Compare
In fact looking at the build output @pomegranited I think there's a bunch of other packages that would be more worth upgrading such as
and a ton of other Anyway this is ready for a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 -- one nit on the CLA link, but this is good to go once that's addressed.
Thanks @sarina :)
- I tested this by reading through the updated files and checking that all the links work.
- I read through the code
-
I checked for accessibility issuesN/A - Updates documentation
- Commit structure follows OEP-0051
e77aec6
to
3840eb6
Compare
This PR was autogenerated
This pr replaces the old GitHub organization, github.com/edx, with the new GitHub organization, github.com/openedx.
Tagging @openedx/tcril-engineering for review, but others are welcome to provide review.
Ref: openedx/axim-engineering#42