Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix tests in ansible free image #1391

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fix tests in ansible free image #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/a11y_reqs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ url="https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodrive
curl -s -L "$url" | tar -xz
chmod +x geckodriver

sudo mv geckodriver "$INSTALL_DIR"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: sudo is not available in our Ansible free image now. Its only usage was in this script and it made no sense to add a new dependency in Dockerfile for just this script. Also it seems like it works fine without sudo in our CI and hence I have removed it from here.

mv geckodriver "$INSTALL_DIR"
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ RUN apt-get update && apt-get install --no-install-recommends -qy \
libmysqlclient-dev \
libssl-dev \
# needed by phantomjs
libfontconfig && \
libfontconfig \
# needed by i18n tests in CI
gettext \
# needed by a11y tests script
curl && \
rm -rf /var/lib/apt/lists/*

RUN locale-gen en_US.UTF-8
Expand Down