This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
fix: install pkg-config dependency for mysqlclient>=2.2.0 #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repositiories that depend on mysqlclient>=2.2.0 will need to install the package pkg-config in their Dockerfile: PyMySQL/mysqlclient#620. This commit installs the pkg-config package in the Dockerfile. If this is missing, then pip install of mysqlclient fails with an error that includes the following: Exception: Can not find valid pkg-config name. Specify MYSQLCLIENT_CFLAGS and MYSQLCLIENT_LDFLAGS env vars manually See edx/edx-arch-experiments#349.
ilee2u
approved these changes
Jul 6, 2023
MichaelRoytman
deleted the
michaelroytman/update-Dockerfile-pkg-config-mysqlclient-dependency
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: None.
Description:
Repositiories that depend on mysqlclient>=2.2.0 will need to install the package pkg-config in their Dockerfile: PyMySQL/mysqlclient#620. This commit installs the pkg-config package in the Dockerfile.
If this is missing, then pip install of mysqlclient fails with an error that includes the following:
See edx/edx-arch-experiments#349.
Author concerns: None.
Dependencies: None.
Installation instructions: None.
Testing instructions:
Build the Dockerfile using
docker build -f Dockerfile ..