Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Python Requirements Update #1521

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Python Requirements Update #1521

merged 2 commits into from
Oct 31, 2023

Conversation

edx-requirements-bot
Copy link
Contributor

Python requirements update. Please review the changelogs for the upgraded packages.

Deleted obsolete pull_requests:
#1520

@edx-requirements-bot
Copy link
Contributor Author

List of packages in the PR without any issue.

  • babel changes from 2.13.0 to 2.13.1
  • charset-normalizer changes from 3.3.0 to 3.3.1
  • cryptography changes from 41.0.4 to 41.0.5
  • edx-lint changes from 5.3.4 to 5.3.6
  • filelock changes from 3.12.4 to 3.13.0
  • newrelic changes from 9.1.0 to 9.1.1
  • pip changes from 23.3 to 23.3.1
  • pydata-sphinx-theme changes from 0.14.1 to 0.14.2
  • pylint-django changes from 2.5.3 to 2.5.5
  • pytest changes from 7.4.2 to 7.4.3
  • testfixtures changes from 7.2.0 to 7.2.2
  • urllib3 changes from 1.26.17 to 1.26.18
  • virtualenv changes from 20.24.5 to 20.24.6

@edx-requirements-bot
Copy link
Contributor Author

These Packages need manual review..

  • [MAJOR] astroid changes from 2.15.8 to 3.0.1
  • [MAJOR] djangorestframework-csv changes from 2.1.1 to 3.0.1
  • [REMOVED] lazy-object-proxy (1.9.0) removed from the requirements
  • [MAJOR] pylint changes from 2.17.7 to 3.0.2
  • [REMOVED] unicodecsv (0.14.1) removed from the requirements
  • [REMOVED] wrapt (1.15.0) removed from the requirements

@MichaelRoytman
fix: set navigation_with_keys value
ef96288 
False was the default value for navigation_with_keys. However, in version 0.14.2 of pydata-sphinx-theme, this default was removed and a warning was added that would be emitted whenever navigation_with_keys was not set. Because of the "SPHINXOPTS = -W" configuration in tox.ini, all warnings are promoted to an error. Therefore, it's necesary to set this value. I have set it to the default value explicitly.

Please see the following GitHub comments for context.
* pydata/pydata-sphinx-theme#1539
* pydata/pydata-sphinx-theme#987 (comment)
MichaelRoytman
MichaelRoytman approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed these changes, and they look good to me.

I'm going to get a second review from a coworker to review my fixes.

schenedx
schenedx approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichaelRoytman MichaelRoytman merged commit 2e7b2dc into master Oct 31, 2023
5 checks passed
@MichaelRoytman MichaelRoytman deleted the jenkins/upgrade-python-requirements-8dec814 branch October 31, 2023 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelRoytman MichaelRoytman MichaelRoytman approved these changes

@schenedx schenedx schenedx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edx-requirements-bot @MichaelRoytman @schenedx