Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Handle fallback video format on CourseUnitNavigationActivity #1835

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

omerhabib26
Copy link
Contributor

Description

LEARNER-9658

  • Show fallback video in case course doesn't have any video quality available

- Show fallback video in case course doesn't have any video quality available
fixes: LEARNER-9658
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bcf1d6d) 1.08% compared to head (d4f8b34) 1.07%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1835      +/-   ##
===========================================
- Coverage      1.08%   1.07%   -0.01%     
  Complexity      137     137              
===========================================
  Files           538     538              
  Lines         26293   26299       +6     
  Branches       3381    3383       +2     
===========================================
  Hits            284     284              
- Misses        25982   25988       +6     
  Partials         27      27              
Files Coverage Δ
...a/org/edx/mobile/model/course/VideoBlockModel.java 10.71% <0.00%> (-0.40%) ⬇️
...org/edx/mobile/module/db/DatabaseModelFactory.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to reproduce the crash for the course having fallback videos. and this code change fixes the crash. 🏎️ 🔥

@omerhabib26 omerhabib26 merged commit 1d7f15d into master Oct 9, 2023
3 of 6 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9658 branch October 9, 2023 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants