Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move the dependabot.yml file to the correct location. #105

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Dec 8, 2022

According to the docs
(https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file)
this file is supposed to be in the .github repo not the
.github/workflows repo since it's not a github actions workflow.

According to the docs
(https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file)
this file is supposed to be in the `.github` repo not the
`.github/workflows` repo since it's not a github actions workflow.
@feanil feanil requested a review from e0d December 8, 2022 16:10
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.97%. Comparing base (fe7b088) to head (2a30737).
Report is 228 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   48.97%   48.97%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           24       24           
  Misses         25       25           
Flag Coverage Δ
unittests 48.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil feanil self-assigned this Dec 8, 2022
@Carlos-Muniz
Copy link

From the documentation: "You must store this file in the .github directory of your repository.", but I think you mean to say "directory" instead of "repo" in your description.

this file is supposed to be in the .github repo not the .github/workflows repo

Copy link
Contributor

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feanil feanil merged commit 49423c9 into master Dec 9, 2022
@feanil feanil deleted the feanil/update_dependabot branch December 9, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants