Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding tests cases. #125

Closed
wants to merge 2 commits into from
Closed

test: adding tests cases. #125

wants to merge 2 commits into from

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Mar 21, 2023

  1. Adding tests

@salman2013 initiated this PR . I Just cherrypick his effort here.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +16.96% 🎉

Comparison is base (b793993) 56.36% compared to head (9c0f79b) 73.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #125       +/-   ##
===========================================
+ Coverage   56.36%   73.33%   +16.96%     
===========================================
  Files           3        4        +1     
  Lines          55       90       +35     
===========================================
+ Hits           31       66       +35     
  Misses         24       24               
Flag Coverage Δ
unittests 73.33% <100.00%> (+16.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
done/tests/test_basic.py 100.00% <100.00%> (ø)
done/tests/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil
Copy link
Contributor

feanil commented Apr 5, 2023

@awais786 is this ready for review?

@feanil
Copy link
Contributor

feanil commented Apr 13, 2023

@awais786 checking back in on this, is this ready for review or are you still working on it?

@awais786
Copy link
Contributor Author

@feanil sorry for late reply. This PR is in internal review. After internal review i will tag you.

@OmarIthawi
Copy link
Member

@awais786 Would you mind taking a look at the other PR here I've done few years ago on the other fork of DoneXBlock:

Please let me know if you have any questions.

@awais786
Copy link
Contributor Author

@OmarIthawi please share your PR.

@OmarIthawi
Copy link
Member

@OmarIthawi please share your PR.

Pardon. I shared the wrong link. Here you go @awais786: https://github.com/pmitros/DoneXBlock/pull/21/files

@feanil
Copy link
Contributor

feanil commented Jun 20, 2023

@awais786 I'm gonna convert this to a draft PR until it is ready for public review and merging.

@feanil feanil marked this pull request as draft June 20, 2023 13:07
@feanil
Copy link
Contributor

feanil commented Jul 24, 2023

@awais786 this has been in Draft for a month, are you still working on it?

@awais786
Copy link
Contributor Author

@feanil I will start working on this tomorrow and try to finish it.

@awais786 awais786 force-pushed the adding-tests branch 2 times, most recently from acb6f85 to 4f76fcc Compare July 25, 2023 10:24
@awais786 awais786 marked this pull request as ready for review July 25, 2023 11:19
@awais786 awais786 closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants