-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding tests cases. #125
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
===========================================
+ Coverage 56.36% 73.33% +16.96%
===========================================
Files 3 4 +1
Lines 55 90 +35
===========================================
+ Hits 31 66 +35
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@awais786 is this ready for review? |
@awais786 checking back in on this, is this ready for review or are you still working on it? |
@feanil sorry for late reply. This PR is in internal review. After internal review i will tag you. |
@awais786 Would you mind taking a look at the other PR here I've done few years ago on the other fork of DoneXBlock: Please let me know if you have any questions. |
@OmarIthawi please share your PR. |
Pardon. I shared the wrong link. Here you go @awais786: https://github.com/pmitros/DoneXBlock/pull/21/files |
@awais786 I'm gonna convert this to a draft PR until it is ready for public review and merging. |
@awais786 this has been in Draft for a month, are you still working on it? |
@feanil I will start working on this tomorrow and try to finish it. |
acb6f85
to
4f76fcc
Compare
@salman2013 initiated this PR . I Just cherrypick his effort here.