Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tag Aximprovements team on weekly maintenance PRs #166

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

thezaeemaanwar
Copy link
Contributor

@thezaeemaanwar thezaeemaanwar commented Aug 23, 2023

Update existing Axim Maintained Repositories

This pull request is related to #849

GitHub Bot will add @openedx/axim-aximprovements as reviewer on weekly maintenance PRs

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 23, 2023

Thanks for the pull request, @thezaeemaanwar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (731b907) 56.36% compared to head (62f7ccc) 56.36%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files           3        3           
  Lines          55       55           
=======================================
  Hits           31       31           
  Misses         24       24           
Flag Coverage Δ
unittests 56.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thezaeemaanwar thezaeemaanwar changed the title CHORE: Tag Aximprovements team on weekly maintenance PRs chore: Tag Aximprovements team on weekly maintenance PRs Aug 23, 2023
@farhan
Copy link
Contributor

farhan commented Sep 1, 2023

@thezaeemaanwar Please squash the commits with the meaningful commit type

Here are some common examples of commit types:

  • feat: This type is used for new features or significant additions to the codebase.
  • fix: It's used when fixing a bug or resolving an issue.
  • docs: Used for documentation-related changes, such as adding or updating documentation.
  • style: This type covers changes related to code style, formatting, or coding conventions but does not affect the code's functionality.
  • refactor: When you make code changes that don't add new features or fix bugs but improve the code's structure, readability, or maintainability, you can use this type.
  • test: Used for adding or modifying tests.
  • chore: This type is for general maintenance tasks, updates, or other non-code-related changes.
  • build: Used when making changes to the build process or build-related files/configurations.
  • ci: For changes related to continuous integration (CI) configurations and scripts.
  • perf: When optimizing the code for better performance, you can use this type.
  • revert: If a commit is reverting a previous change, you can use this type to indicate that.
  • deps: Used for dependency-related changes, such as updating, adding, or removing dependencies.

@thezaeemaanwar thezaeemaanwar merged commit 510c606 into master Sep 5, 2023
16 of 17 checks passed
@thezaeemaanwar thezaeemaanwar deleted the zaeema-tag_aximprovements_in_pr branch September 5, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants