Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running tests using python 3.12 #207

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Running tests using python 3.12 #207

merged 6 commits into from
Feb 29, 2024

Conversation

salman2013
Copy link
Contributor

@salman2013 salman2013 commented Feb 14, 2024 •
edited
Loading

@salman2013 salman2013 changed the title chore: update CI for 3.11 and 3.12 Running tests using python 3.11 and 3.12 Feb 14, 2024
@salman2013 salman2013 marked this pull request as ready for review February 14, 2024 12:56
feanil
feanil reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is passing on the newer versions, can you update the classifiers in setup.py as a part of this PR as well? Then I think we can merge and release this.

@feanil feanil mentioned this pull request Feb 14, 2024
Closed
@salman2013
Copy link
Contributor Author

@feanil i have updated the classifiers.

farhan
farhan reviewed Feb 20, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@salman2013 salman2013 mentioned this pull request Feb 22, 2024
Closed
@salman2013 salman2013 changed the title Running tests using python 3.11 and 3.12 Running tests using python 3.12 Feb 22, 2024
farhan
farhan requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change

@salman2013 salman2013 merged commit fcc5219 into openedx:master Feb 29, 2024
10 checks passed
@salman2013 salman2013 deleted the salman/python-version-update branch February 29, 2024 11:15
@feanil feanil linked an issue Apr 3, 2024 that may be closed by this pull request
Test DoneXBlock on Python 3.11 #216
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

@feanil feanil Awaiting requested review from feanil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test DoneXBlock on Python 3.11
3 participants
@salman2013 @feanil @farhan