Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0d/makefile improvements #45

Merged
merged 42 commits into from
Jun 17, 2022
Merged

E0d/makefile improvements #45

merged 42 commits into from
Jun 17, 2022

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Jun 16, 2022

We will be using this XBlock as an exemplar for repos to meet OEP-55 requirements. It's not up to current best practice in a number of ways. This is the start of that journey :)

@e0d e0d force-pushed the e0d/makefile-improvements branch from 6a25a59 to 3d23646 Compare June 16, 2022 19:05
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ea2ed2d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage          ?   50.98%           
=========================================
  Files             ?        3           
  Lines             ?       51           
  Branches          ?        0           
=========================================
  Hits              ?       26           
  Misses            ?       25           
  Partials          ?        0           
Flag Coverage Δ
unittests 50.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2ed2d...9fb1ba0. Read the comment docs.

@e0d
Copy link
Contributor Author

e0d commented Jun 16, 2022

@feanil I have CI working end-to-end, albeit for a meaningless test. There are new commits since your review. Let me know if you want another look before I merge.

@e0d e0d merged commit a878c17 into master Jun 17, 2022
@e0d e0d deleted the e0d/makefile-improvements branch June 17, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants