Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0d/upgrade codecov action #68

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Sep 19, 2022

Upgrading the checkout and codecov GitHub actions.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 50.98% // Head: 50.98% // No change to project coverage 👍

Coverage data is based on head (bb597e8) compared to base (dee79d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files           3        3           
  Lines          51       51           
=======================================
  Hits           26       26           
  Misses         25       25           
Flag Coverage Δ
unittests 50.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e0d e0d requested a review from sarina September 19, 2022 19:47
@e0d
Copy link
Contributor Author

e0d commented Sep 19, 2022

@sarina I've added and removed a toy python function to make sure that Codecov was triggered and behaved correctly at version 3.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - good testing strategy too.

Do you know if there are many breaking changes from 1 -> 2 -> 3? I wonder what it would take to get others to upgrade their repos.

@e0d
Copy link
Contributor Author

e0d commented Sep 19, 2022

Looks good to me - good testing strategy too.

Do you know if there are many breaking changes from 1 -> 2 -> 3? I wonder what it would take to get others to upgrade their repos.

There are some breaking changes, but they don't affect DoneXBlock. A more careful review of other uses would be required.

@e0d e0d merged commit f1e180b into openedx:master Sep 19, 2022
@e0d e0d deleted the e0d/upgrade-codecov-action branch September 19, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants