Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-6] OEP-18 Compliance and tests with Python 3.8 #6

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

ericfab179
Copy link

@ericfab179 ericfab179 commented Jun 13, 2020

Update setup classifiers.
Update setup.py install_requirements definition.
Create travis file.
Create tox configuration file.
create pip_tools, base, test, tox and travis requirements files.
Create Makefile and add upgrade command.
Include requirements files generated using upgrade command.
Update MANIFEST.in.
Update openedx.yml.

Reviewers

@openedx-webhooks
Copy link

Thanks for the pull request, @ericfab179! I've created OSPR-4699 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Update setup.py install_requirements definition.
Create travis file. Use python 3.5, 3.6 and 3.8 for tests.
Create tox configuration file.
create pip_tools, base, test, tox and travis requirements files.
Create Makefile and add upgrade command.
Include requirements files generated using upgrade command.
Update MANIFEST.in.
Update openedx.yml.
@ericfab179 ericfab179 marked this pull request as ready for review June 13, 2020 17:19
@jmbowman jmbowman merged commit 83503a5 into openedx:master Jun 18, 2020
@openedx-webhooks
Copy link

@ericfab179 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program merged and removed needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants