-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragon table deprecation migration to DataTable #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.
@abdullahwaheed I don't think the changes are playing nice when I tested it locally. All the fields of the ProgramRecord component are displaying vertically rather than horizontally as part of the table. A screenshot can be seen here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to using the DataTable
component appears to have broken the ProgramRecord table. Please see comment and screenshot.
will test it locally and make the required changes |
@justinhynes it working fine on local env, screenshot is attached. Please pull latest code and check. if the issue persists, could you please provide the testing env you are using? |
@abdullahwaheed I'll check it again this morning and get back to you. Thanks. I was testing this with a local devstack instance and using the edx.org theme. |
i think there are some conflicting styles there, let me check this with |
@justinhynes could you please test it again |
@abdullahwaheed Sorry! I missed this message. I took another look this morning and it looks good! |
Ticket
Migrate off deprecated Paragon components
What has changed
Removed deprecated
Table
component of paragon and updated it withDataTable
References
Paragon Table
Paragon DataTable