Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon table deprecation migration to DataTable #1691

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated Table component of paragon and updated it with DataTable

References

Paragon Table
Paragon DataTable

@abdullahwaheed abdullahwaheed self-assigned this Jun 17, 2022
Copy link

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

@justinhynes
Copy link
Contributor

justinhynes commented Jul 5, 2022

@abdullahwaheed I don't think the changes are playing nice when I tested it locally. All the fields of the ProgramRecord component are displaying vertically rather than horizontally as part of the table. A screenshot can be seen here:
image

Versus how it looked before:
image

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to using the DataTable component appears to have broken the ProgramRecord table. Please see comment and screenshot.

@abdullahwaheed
Copy link
Contributor Author

@abdullahwaheed I don't think the changes are playing nice when I tested it locally. All the fields of the ProgramRecord compoenent are displying vertically then horizontally as part of the table. A screenshot can be seen here: image

will test it locally and make the required changes

@abdullahwaheed
Copy link
Contributor Author

@justinhynes it working fine on local env, screenshot is attached. Please pull latest code and check. if the issue persists, could you please provide the testing env you are using?
image

@justinhynes
Copy link
Contributor

@abdullahwaheed I'll check it again this morning and get back to you. Thanks. I was testing this with a local devstack instance and using the edx.org theme.

@justinhynes
Copy link
Contributor

justinhynes commented Jul 6, 2022

I tested this again and I think I have narrowed this down to an issue with the edx.org theme specifically.

I pulled this branch, ran make static and then attempted to access a ProgramRecord example.

I switched to the openedx theme and see:
image

After switching to the edx.org theme:
image

@abdullahwaheed
Copy link
Contributor Author

i think there are some conflicting styles there, let me check this with edx.org theme as well

@abdullahwaheed
Copy link
Contributor Author

@justinhynes could you please test it again

@justinhynes
Copy link
Contributor

@abdullahwaheed Sorry! I missed this message. I took another look this morning and it looks good!

@abdullahwaheed abdullahwaheed merged commit f825660 into master Jul 26, 2022
@abdullahwaheed abdullahwaheed deleted the abdullah/remove-table-deprecation branch July 26, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants