Handle node dependencies using --unsafe-perm. #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/node-dependencies
branch
4 times, most recently
from
11fb933
to
7fb5553
Compare
dianakhuang
changed the title
mikix
reviewed
Jul 19, 2018
Makefile
Outdated
| @@ -20,7 +20,7 @@ production-requirements: ## Install requirements for production | |||
| pip install -r requirements.txt | |||
|
|
|||
| requirements: ## Install requirements for local development | |||
| npm install | |||
| npm install --unsafe-perm | |||
There was a problem hiding this comment.
Maybe a comment for why this otherwise bad-looking flag is added here, for future archeologists?
dianakhuang
force-pushed
the
diana/node-dependencies
branch
from
5e396a1
to
1e77bae
Compare
dianakhuang
force-pushed
the
diana/node-dependencies
branch
from
1e77bae
to
9ce3ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for dealing with issues within docker and running everything from the docker root.
Other places where this issue has been mentioned (along with this fix): npm/npm#17431
sass/node-sass#2006
We need a more robust solution, but this is blocking any updates to
package.jsonorpackage-lock.json.