refactor: address comments

openedx · Jun 21, 2024 · 6e4dce8 · 6e4dce8
1 parent 69a2f30
commit 6e4dce8
Show file tree

Hide file tree

Showing 12 changed files with 35 additions and 514 deletions.
diff --git a/ecommerce/credit/tests/test_views.py b/ecommerce/credit/tests/test_views.py
@@ -131,6 +131,9 @@ def _assert_success_checkout_page(self, sku=None):
         response = self.client.get(self.path)
         self.assertEqual(response.status_code, 200)
         if sys.version_info > (3, 9):
+            # assertDictContainsSubset is depreciated in python version>3.9
+            # context.response return ContextList object, belwo statements will convert it to dict
+            # assertLessEqual method is used instead of depreciated assertDictContainsSubset method
             context = {}
             for i, ctx in enumerate(response.context):
                 if isinstance(ctx, dict):

diff --git a/pylintrc_backup b/pylintrc_backup
diff --git a/requirements/base.in b/requirements/base.in
@@ -31,7 +31,6 @@ edx-django-utils
 edx-drf-extensions>=8.13.0  # 8.13 fixes forgiven JWTs for ecommerce
 edx-django-sites-extensions
 edx-ecommerce-worker
-edx-lint
 edx-opaque-keys
 edx-rbac
 edx-rest-api-client
@@ -47,7 +46,6 @@ markdown==3.4.3
 mysqlclient
 newrelic
 ndg-httpsclient
-needle
 openedx-atlas
 path.py==7.2
 paypalrestsdk