feat: add python312 support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to merge #264 before this to minimise the breaking changes. |
UsamaSadiq
force-pushed
the
jenkins/python312-support-15fef61
branch
4 times, most recently
from
be387d3
to
65f7dce
Compare
UsamaSadiq
force-pushed
the
jenkins/python312-support-15fef61
branch
from
65f7dce
to
95c0300
Compare
UsamaSadiq
reviewed
Mar 6, 2024
UsamaSadiq
reviewed
Mar 6, 2024
| @@ -10,3 +10,7 @@ | |||
|
|
|||
| # Common constraints for edx repos | |||
| -c https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt | |||
|
|
|||
| backports.zoneinfo==0.2.1; python_version<'3.9' | |||
There was a problem hiding this comment.
Needed for Python 3.12 compatibility. Django 4+ adds this import because we currently update our requirements in a python 3.8 env.
UsamaSadiq
reviewed
Mar 6, 2024
UsamaSadiq
reviewed
Mar 6, 2024
| wheel # For generation of wheels for PyPI |
There was a problem hiding this comment.
needed for docs checks to pass. Specifically needed for the python build sdist bdist_wheel command.
UsamaSadiq
reviewed
Mar 6, 2024
| DJANGO_SETTINGS_MODULE=test_settings | ||
| PYTHONPATH = {toxinidir}/:{toxinidir}/edx_ace | ||
| basepython = python3.8 |
There was a problem hiding this comment.
Removing basepython because we want tox to control python version instead.
UsamaSadiq
approved these changes
Mar 6, 2024
UsamaSadiq
force-pushed
the
jenkins/python312-support-15fef61
branch
from
2900b0c
to
ba79ad7
Compare
UsamaSadiq
force-pushed
the
jenkins/python312-support-15fef61
branch
from
d4d4f6a
to
c6c2c6c
Compare
asadazam93
approved these changes
Mar 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the details, check the issue edx/edx-arch-experiments#553